[scotia]

Hi Bossa,

I was having the same trouble as the chap before with a script error when searching a postcode.

Bearing in mind in know very little about python...

The returned url from weather zone has a www. at the front which is missing from the script.
Also, unfortunately there are TWO HTML lists with class typ2, which breaks the script. It only checks one of the two lists, which is the one containing news. Because the list you want is in the "structure_middle" div I included a step before extracting the list to limit the html to just that div.
The third thing is that the length of skimmed is 1, even though the search returns many results. So I changed it to the length of the locations array.

To that end, I've created a patch to fix things. It has some log() calls which really shouldn't be there, feel free to remove them. I'm sure there are ten better ways to accomplish the same thing (like checking for (www\.)? at the start of the URL.

I hope you don't mind me fiddling with your code.

Regards
Scott

Code:

--- default.py.dist     2012-02-27 15:49:06.000000000 +1100
+++ default.py  2012-02-27 15:44:40.000000000 +1100
@@ -521,7 +521,7 @@
         text = keyboard.getText()

         #need to submit the postcode to the weatherzone search
-        searchURL = 'http://weatherzone.com.au/search/'
+        searchURL = 'http://www.weatherzone.com.au/search/'
         user_agent = 'Mozilla/4.0 (compatible; MSIE 5.5; Windows NT)'
         host = 'www.weatherzone.com.au'
         headers = { 'User-Agent' : user_agent, 'Host' : host }
@@ -530,9 +530,11 @@
         req = urllib2.Request(searchURL, data, headers)
         response = urllib2.urlopen(req)
         resultPage = str(response.read())
+#        log("OzWeather: got response", resultPage);
         #was there only one match?  If so it returns the page for that match so we need to check the URL
         responseurl = response.geturl()
-        if responseurl != 'http://weatherzone.com.au/search/':
+#        log("OzWeather: got responseurl", responseurl);
+        if responseurl != 'http://www.weatherzone.com.au/search/':
             #we were redirected to an actual result page
             locationName = common.parseDOM(resultPage, "h1", attrs = { "class": "unenclosed" })
             locationName = str.split(locationName[0], ' Weather')
@@ -540,17 +542,24 @@
             locationids = [responseurl]
         else:
             #we got back a page to choose a more specific location
-            skimmed = common.parseDOM(resultPage, "ul", attrs = { "class": "typ2" })
+            middle = common.parseDOM(resultPage, "div", attrs = { "id": "structure_middle" })
+#            log("OzWeather: got middle", middle);
+            skimmed = common.parseDOM(middle, "ul", attrs = { "class": "typ2" })
+#            skimmed = common.parseDOM(resultPage, "ul", attrs = { "class": "typ2" })
+#            log("OzWeather: got skimmed", skimmed);
             #ok now get two lists - one of the friendly names
             #and a matchin one of the URLs to store
             locations = common.parseDOM(skimmed[0], "a")
+#            log("OzWeather: got locations", locations);
+#            log("OzWeather: got locations length", len(locations));
             templocs = common.parseDOM(skimmed[0], "a", ret="href")
+#            log("OzWeather: got templocs", templocs);
             #build the full urls
             locationids = []
             for count, loc in enumerate(templocs):
                 locationids.append(WeatherZoneURL + loc)
             #if we did not get enough data back there are no locations with this postcode
-            if len(skimmed)<=1:
+            if len(locations)<=1:
                 locations = []
                 locationids = []