2021-06-27, 02:34
Brilliant work, bossanova808!
Just an observation (HA! Pun!), since you've added the option to configure colours via xml modification (e.g. [COLOR _colour_text_dim_] replaced by ADDON.getSetting('colour_text_dim'), you can no longer be a masochist and simply copy the appropriate skin files from the zipped patcher into your Kodi install. You'll end up with no visible text from MyWeather.xml!
In other words, you now MUST install & run the skin patcher to use the skin files, because only the patcher stores those configured colour setting fields, then uses python to replace the text anchor tags in the .xml.
This is not a problem that needs "fixing", since you clearly tell people to "USE THE PATCHER", but you might want to make note of it on the wiki.
I suppose, for people who insist on doing it manually regardless, they'll need to manually search/replace the placeholders themselves before manually relocating the skin files. Yeah, UGH to that, but there'll always be one who'll want to try.
Just an observation (HA! Pun!), since you've added the option to configure colours via xml modification (e.g. [COLOR _colour_text_dim_] replaced by ADDON.getSetting('colour_text_dim'), you can no longer be a masochist and simply copy the appropriate skin files from the zipped patcher into your Kodi install. You'll end up with no visible text from MyWeather.xml!
In other words, you now MUST install & run the skin patcher to use the skin files, because only the patcher stores those configured colour setting fields, then uses python to replace the text anchor tags in the .xml.
This is not a problem that needs "fixing", since you clearly tell people to "USE THE PATCHER", but you might want to make note of it on the wiki.
I suppose, for people who insist on doing it manually regardless, they'll need to manually search/replace the placeholders themselves before manually relocating the skin files. Yeah, UGH to that, but there'll always be one who'll want to try.
