2021-07-15, 02:23
They're wrong, in a sense, but you haven't actually asked them the right question.
What we've confirmed it that Kodi clears the folder for the add-on on every add-on update. Easy to test for yourself, as Ronie explicitly did...we're not talking about Kodi or OSMC updates here. Add-on updates (skin updates) specifically.
I see in your OSMC thread:
What it does is it copies the relevant files and adds .original to the end of the file name and it uses that to determine if it needs to update the skin files again
You're not hearing me it seems. If the .original files are already there, it just skips the backup bit (because it already has backups), and tries to do the patch anyway. It does NOT use their presense to determine whether to run the patch again. Only uses it to determine whether to back up again. If you run the patcher and choose patch - it WILL try and patch. Simple as that - the ball is entirely in your court.
Also:
updating Kodi should wipe out all files in the skin folder, (Estuary in this case)
No, what we are saying is that Skin updates will (and should) clear the folder, specifically. Later you say:
Ok so it’s problematic if the skin is updated but OSMC is leaving old files in the skin folder when it updates
No, it's not. It's actually desirable behaviour, and sensible on their part, that they don't nuke other files. Indeed it would be really bad if they did.
Again, all this is actually irrelevant. You can completely ignore the issue of the .original files, unless and specifically only if the notification you are getting specifically starts with 'Exiting - as error when backing up....'. Which you have not said. It's all a furphy, based on your incorrect assumption that those .original files block the patch process - they do not, and it is not your issue. See these two lines specifically - they prevent the backup process (and only the backup process) from being attempted, if the .original files are already there. So those files being there is definitely NOT your issue...
https://github.com/bossanova808/reposito...er.py#L107
https://github.com/bossanova808/reposito...er.py#L117
The very simple patch process is just a series of file copies (with a bit of search and replace in those files before the copying)...and that is the bit that is apparently failing - so, ok - but there's simply no way for me to work out why it is failing without that debug log. As they say, their update process does update skin files as part of it (and not using the Kodi mechanism for this clearly, or the .originals WOULD be cleared). Thus the most likely explanation at this stage is something about their update process make those skin files untouchable (probably until the next reboot) - by the patcher.
It's all a complete guess though...all I know for sure is that the .original files remaining present is NOT the issue. And the easy way to solve the issue is (well, should be) - grab the debug log when it fails.
What we've confirmed it that Kodi clears the folder for the add-on on every add-on update. Easy to test for yourself, as Ronie explicitly did...we're not talking about Kodi or OSMC updates here. Add-on updates (skin updates) specifically.
I see in your OSMC thread:
What it does is it copies the relevant files and adds .original to the end of the file name and it uses that to determine if it needs to update the skin files again
You're not hearing me it seems. If the .original files are already there, it just skips the backup bit (because it already has backups), and tries to do the patch anyway. It does NOT use their presense to determine whether to run the patch again. Only uses it to determine whether to back up again. If you run the patcher and choose patch - it WILL try and patch. Simple as that - the ball is entirely in your court.
Also:
updating Kodi should wipe out all files in the skin folder, (Estuary in this case)
No, what we are saying is that Skin updates will (and should) clear the folder, specifically. Later you say:
Ok so it’s problematic if the skin is updated but OSMC is leaving old files in the skin folder when it updates
No, it's not. It's actually desirable behaviour, and sensible on their part, that they don't nuke other files. Indeed it would be really bad if they did.
Again, all this is actually irrelevant. You can completely ignore the issue of the .original files, unless and specifically only if the notification you are getting specifically starts with 'Exiting - as error when backing up....'. Which you have not said. It's all a furphy, based on your incorrect assumption that those .original files block the patch process - they do not, and it is not your issue. See these two lines specifically - they prevent the backup process (and only the backup process) from being attempted, if the .original files are already there. So those files being there is definitely NOT your issue...
https://github.com/bossanova808/reposito...er.py#L107
https://github.com/bossanova808/reposito...er.py#L117
The very simple patch process is just a series of file copies (with a bit of search and replace in those files before the copying)...and that is the bit that is apparently failing - so, ok - but there's simply no way for me to work out why it is failing without that debug log. As they say, their update process does update skin files as part of it (and not using the Kodi mechanism for this clearly, or the .originals WOULD be cleared). Thus the most likely explanation at this stage is something about their update process make those skin files untouchable (probably until the next reboot) - by the patcher.
It's all a complete guess though...all I know for sure is that the .original files remaining present is NOT the issue. And the easy way to solve the issue is (well, should be) - grab the debug log when it fails.
