[bossanova808]

Ok  so this the the relevant stuff from all that mess - https://pastebin.com/raw/uTGFdTEX   - From that, the patcher ran, and no errors were raised (you didn't see any errors, right?  By 'failed' you mean it just didn't result in changes...if you DID see an error...what was it?  Because it did not get raised by OzWeather, according to this log...).  i.e. Kodi and Python believe the copies were succesfully made (new backups were not as .original files present, but that did indeed not stop the patching as mentioned).  So (assuming you're 100% sure this is the 'failed' run) - I don't think it has failed at all, I think it did precisely what it should do.

e.g.

Code:


2021-07-17 09:38:53.396 T:3130 DEBUG <general>: ### OzWeather Skin Patcher 0.2.7 - Patching & copying /home/osmc/.kodi/addons/script.ozweather-skinpatcher/resources/skin-files/estuary/VideoFullScreen.xml to /usr/share/kodi/addons/skin.estuary/xml


Kodi is told to reload the skin:

Code:


2021-07-17 09:38:53.405 T:3130 DEBUG <general>: ### OzWeather Skin Patcher 0.2.7 - Reloading skin to pick up changes


So, that's exactly what happens on every other platform I have run it on (CoreElec many times, Windows (two separate machines) - many times, etc) - so, in fact, I think the issue might be this:

Code:


2021-07-17 09:38:53.411 T:2841 INFO <general>: Suppressing skin reload as the walkthrough is running


...no idea what that is (some sort of OSMC new version notification thing??) = but it's blocking the skin reload that would show the changes.  Without that, you'd have to reboot to see them.

So from that, the conclusion would have to be the patcher is running just fine, & succeeding, but OSMC is blocking the skin changes from becoming visible by blocking that reload.

If the skin changes are not present on the next reboot, then it's probably queuing up some changes for that reboot that over-write the patched skin (this is a wild guess).  But there is not reason to think the patcher is not working 100% really.  I can't really see a scenario where Kodi/Python think a file has copied when it hasn't done so successfully.  In 15 years of Python, that results in an exception 100% of times I've seen that...

Perhaps OSMC could be convinced to do a skin reload after the walkthrough (...perhaps only if it knows one was requested - it does know this, so should not be hard for them to store a flag then trigger a reload if the flag is set - and appropriate given Kodi has requested one...). 
Or you could e.g. bind a remote key to reload skin and manually do it after that walkthrough thing is finished.  It's actually a very handy remote button to have...well, for dev stuff anyway.