[nonJon]

Can't figure out what it is about my setup but 90% of the time reloadskin() blows up on me. Tried many nightlies, 32 and 64 bit, on a Win7 box. I don't see anything remarkable in the log and would appreciate some extra eyes.


KODI log

[sualfred]

Yep, it's a pain to work on a skin atm and it's happening since weeks. Sometimes I'm able to refresh a couple of times without any crash but mostly it's crashing on each single skin reload.

[nonJon]

Thanks for the confirmation. Reckon I'll just have to shelve the project until this is working reliably.

[jurialmunkey]

I've also noticed this (I originally thought it was because I was building a Wayland version from source then running in portable mode, but on further testing it seems like it is across the board).

I've found that binding a key to ReloadSkin() directly (I use F5) seems to work better than using the shutdown menu to reload. It does still crash, but not as often.

[sualfred]

Makes no difference. Mapped control button in a dialog, keyboard or via Json RPC.. crashing . Randomly and not reproduceable.
It just seems that it happens less on lightweight windows/dialogs like the videoosd.

[nonJon]

Is there such thing as a stop work ticket?

[manfeed]

These are not good times for skinners I think...

[jurialmunkey]

Makes no difference. Mapped control button in a dialog, keyboard or via Json RPC.. crashing . Randomly and not reproduceable.
It just seems that it happens less on lightweight windows/dialogs like the videoosd.

Yeah, you are right. I had a bunch of crashes using a mapped button just now. Struggling to find a pattern other than the crashes happen after skin code is changed. Reloading without making any changes seems to be fine most of the time.

[sualfred]

All I can say is that it's happening since I've started to port Embuary to Leia. And I started in the beginning of March. Hard to find out which PR is causing it without having access to very old nightlies.

[sualfred]

*bump*
Still crashing without any error message back to desktop.
Nothing is mentioned in a debug log and no dmp file will be created

Code:

...
13:06:34.675 T:8136   DEBUG: CInputManager::HandleKey: f5 (0xf094) pressed, action is XBMC.ReloadSkin()
13:06:34.676 T:8136    INFO: Unloading old skin ...
13:06:34.685 T:8136   DEBUG: ------ Window Deinit (Home.xml) ------
13:06:34.685 T:8136   DEBUG: FreeVisualisation() done

Since no one has opened a ticket yet -> https://trac.kodi.tv/ticket/17935

[komplex]

This is getting increasingly annoying especially when a skin needs to reload after a setting change or even worse trying to change to another skin just force closes Kodi

[nonJon]

It has gotten substantially worse for me. I often have to reboot my windows box b/c kodi hangs so hard the process cannot be terminated.

[tjost]

search errors of your skin in the log file. 
after removing errors there is no problem with reload skin on Leia.

[nonJon]

Fixed!

[sualfred]

Not in my case. Skin reload still crashes

@garbear
Is this commit already in the nightly of today? Dunno if the merged PR wasn't too late.