[sualfred]

Thx, will test it on Tuesday when I'm back at home.

[Hitcher]

Thought I'd give this a go again as I want to start work on moving labels to strings.po (thankfully the latest build runs fine) but I can't find how to move label to language file in the context menu.



Awesome work by the way.

EDIT: Just remembered you told me it was ctrl+shift+m.

EDIT2: I guess the next question is can I speed this process up somehow?

[phil65]

Thought I'd give this a go again as I want to start work on moving labels to strings.po (thankfully the latest build runs fine) but I can't find how to move label to language file in the context menu.



Awesome work by the way.

EDIT: Just remembered you told me it was ctrl+shift+m.

EDIT2: I guess the next question is can I speed this process up somehow?

so ctrl+shift+m works for you?

[phil65]

The visibilty condition of that context menu entry was broken indeed. Should be fixed with https://github.com/phil65/SublimeKodi/co...1841a129c1

[Hitcher]

All good now thanks.

One thing that would be useful when checking labels would be that the label gets selected when you press enter.

[phil65]

you mean when calling "check labels" from command palette?
Not sure if the API allows that in a nice manner.

[Hitcher]

No worries, I've finished moving them all now anyway.

Thanks.

[phil65]

Added a custom syntax highlighting file for Kodi Skin XMLs.
If all works fine then you should get blue-colored VAR/INFO/LOCALIZE references.

[phil65]

...and also added support for Include/Font/Var names in autocompletion. (so if you press crtl+space then you can quickly search and insert the include /var name)

[Hitcher]

Just found out that strings in variables aren't picked up (no surrounding labels tags I guess).

@Hitcher: Many thanks for moving the strings into the language file. I prepared a first draft of a German language file (strings.po), which is generally based on the German translation of the confluence skin and was completed where necessary, but I tried to meet the length of the original strings, which - however - was not always possible. So some German strings are not fitting into the respective boxes just like expected in an earlier post. Since I do not know how to attach 'strings.po' to a post, send me a PM if someone is interested in testing the draft German translation.

However, it seems as if not yet all strings have been moved, e.g. "Watch Now" in the detailed view of a film or "TV Show Information" as well as the explanation/help entries of the Skin-Options on the right side of the menu

[phil65]

Just found out that strings in variables aren't picked up (no surrounding labels tags I guess).

@Hitcher: Many thanks for moving the strings into the language file. I prepared a first draft of a German language file (strings.po), which is generally based on the German translation of the confluence skin and was completed where necessary, but I tried to meet the length of the original strings, which - however - was not always possible. So some German strings are not fitting into the respective boxes just like expected in an earlier post. Since I do not know how to attach 'strings.po' to a post, send me a PM if someone is interested in testing the draft German translation.

However, it seems as if not yet all strings have been moved, e.g. "Watch Now" in the detailed view of a film or "TV Show Information" as well as the explanation/help entries of the Skin-Options on the right side of the menu

could you post the exact code of the labels which are not picked up?

[Hitcher]

Here's a few -

PHP Code:

    <variable name="RatingCountry">
        <value condition="Stringcompare(Skin.String(RatingCountry),US)">US</value>
        <value condition="Stringcompare(Skin.String(RatingCountry),UK)">UK</value>
        <value condition="Stringcompare(Skin.String(RatingCountry),Germany)">Germany</value>
        <value>US</value>
    </variable>

    <variable name="NextVideo">
        <value condition="VideoPlayer.Content(episodes)">Next Episode</value>
        <value condition="VideoPlayer.Content(movies)">Next Movie</value>
        <value>Next Video</value>
    </variable 


https://github.com/HitcherUK/skin.ftv/bl...iables.xml

[phil65]

hmm the thing is, if I would check all those too I would probably get a lot of false positives because Vars can be used for texture paths / labels / onclicks whatever. Not sure if I will be able to get that right 100%.

As an idea: Perhaps checkin all values which only contain a-z, A-Z, 0-9 and whitespace ?

[Hitcher]

No way of checking where the var is coming from?

[phil65]

No way of checking where the var is coming from?

In theory yes, but hard to do. Some pure text-based recognition would be much easier to implement.
But feel free to put it on issues list, will give it a go then when I feel adventurous