Kodi Community Forum

Full Version: [Release] DVBViewer Recording Service PVR
You're currently viewing a stripped down version of our content. View the full version with proper formatting.
Hi

The nightly build dated today neither works with Recording service 1.26

Any information about?

Cheers
Hi,

Waka sent me his channels.dat + favourites.html but I'm still unable to reproduce this. No corruption happening here. Neither with Frodo nor with current nightly. Right now I'm merging Portisch stuff + rewriting a bunch of code and hope to have something ready to test by the end of next week.

Is any of you guys willing to help me with pin pointing the memory corruption? Preferable via chat (irc://irc.freenode.net/xbmc-dev, Nick: manue|).
(2013-06-15, 22:16)manül Wrote: [ -> ]Hi,

Waka sent me his channels.dat + favourites.html but I'm still unable to reproduce this. No corruption happening here. Neither with Frodo nor with current nightly. Right now I'm merging Portisch stuff + rewriting a bunch of code and hope to have something ready to test by the end of next week.

Is any of you guys willing to help me with pin pointing the memory corruption? Preferable via chat (irc://irc.freenode.net/xbmc-dev, Nick: manue|).

Thanks manül

I send you a PM with link to get the 2 files

Cheers
I also had the same problem. Here is the fix:

Code:
addons/pvr.dvbviewer/src/DvbData.cpp | 4 ++--
addons/pvr.dvbviewer/src/DvbData.h   | 2 +-
addons/pvr.dvbviewer/src/client.cpp  | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/pvr.dvbviewer/src/DvbData.cpp b/addons/pvr.dvbviewer/src/DvbData.cpp
index f67df23..a1d2fce 100644
--- a/addons/pvr.dvbviewer/src/DvbData.cpp
+++ b/addons/pvr.dvbviewer/src/DvbData.cpp
@@ -513,7 +513,7 @@ bool Dvb::OpenLiveStream(const PVR_CHANNEL& channelinfo)
   if (m_tsBuffer)
     SAFE_DELETE(m_tsBuffer);
   XBMC->Log(LOG_INFO, "Timeshifting starts; url=%s",
-      GetLiveStreamURL(channelinfo).c_str());
+      GetLiveStreamURL(channelinfo));
   m_tsBuffer = new TimeshiftBuffer(GetLiveStreamURL(channelinfo),
       g_strTimeshiftBufferPath);
   return m_tsBuffer->IsValid();
@@ -554,7 +554,7 @@ long long Dvb::LengthLiveStream(void)
   return m_tsBuffer->Length();
}

-CStdString Dvb::GetLiveStreamURL(const PVR_CHANNEL& channelinfo)
+const char * Dvb::GetLiveStreamURL(const PVR_CHANNEL& channelinfo)
{
   SwitchChannel(channelinfo);
   return m_channels[channelinfo.iUniqueId - 1].strStreamURL;
diff --git a/addons/pvr.dvbviewer/src/DvbData.h b/addons/pvr.dvbviewer/src/DvbData.h
index 517e219..70adb1b 100644
--- a/addons/pvr.dvbviewer/src/DvbData.h
+++ b/addons/pvr.dvbviewer/src/DvbData.h
@@ -248,7 +248,7 @@ public:
   long long SeekLiveStream(long long iPosition, int iWhence /* = SEEK_SET */);
   long long PositionLiveStream(void);
   long long LengthLiveStream(void);
-  CStdString GetLiveStreamURL(const PVR_CHANNEL& channelinfo);
+  const char * GetLiveStreamURL(const PVR_CHANNEL& channelinfo);

protected:
   virtual void *Process(void);
diff --git a/addons/pvr.dvbviewer/src/client.cpp b/addons/pvr.dvbviewer/src/client.cpp
index 3d0d1e7..6f8ee52 100644
--- a/addons/pvr.dvbviewer/src/client.cpp
+++ b/addons/pvr.dvbviewer/src/client.cpp
@@ -494,7 +494,7 @@ const char *GetLiveStreamURL(const PVR_CHANNEL &channel)
   if (!DvbData || !DvbData->IsConnected())
     return "";

-  return DvbData->GetLiveStreamURL(channel).c_str();
+  return DvbData->GetLiveStreamURL(channel);
}

bool CanPauseStream(void)
(2013-06-26, 11:36)Uukrul Wrote: [ -> ]I also had the same problem. Here is the fix:

Code:
addons/pvr.dvbviewer/src/DvbData.cpp | 4 ++--
addons/pvr.dvbviewer/src/DvbData.h   | 2 +-
addons/pvr.dvbviewer/src/client.cpp  | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/addons/pvr.dvbviewer/src/DvbData.cpp b/addons/pvr.dvbviewer/src/DvbData.cpp
index f67df23..a1d2fce 100644
--- a/addons/pvr.dvbviewer/src/DvbData.cpp
+++ b/addons/pvr.dvbviewer/src/DvbData.cpp
@@ -513,7 +513,7 @@ bool Dvb::OpenLiveStream(const PVR_CHANNEL& channelinfo)
   if (m_tsBuffer)
     SAFE_DELETE(m_tsBuffer);
   XBMC->Log(LOG_INFO, "Timeshifting starts; url=%s",
-      GetLiveStreamURL(channelinfo).c_str());
+      GetLiveStreamURL(channelinfo));
   m_tsBuffer = new TimeshiftBuffer(GetLiveStreamURL(channelinfo),
       g_strTimeshiftBufferPath);
   return m_tsBuffer->IsValid();
@@ -554,7 +554,7 @@ long long Dvb::LengthLiveStream(void)
   return m_tsBuffer->Length();
}

-CStdString Dvb::GetLiveStreamURL(const PVR_CHANNEL& channelinfo)
+const char * Dvb::GetLiveStreamURL(const PVR_CHANNEL& channelinfo)
{
   SwitchChannel(channelinfo);
   return m_channels[channelinfo.iUniqueId - 1].strStreamURL;
diff --git a/addons/pvr.dvbviewer/src/DvbData.h b/addons/pvr.dvbviewer/src/DvbData.h
index 517e219..70adb1b 100644
--- a/addons/pvr.dvbviewer/src/DvbData.h
+++ b/addons/pvr.dvbviewer/src/DvbData.h
@@ -248,7 +248,7 @@ public:
   long long SeekLiveStream(long long iPosition, int iWhence /* = SEEK_SET */);
   long long PositionLiveStream(void);
   long long LengthLiveStream(void);
-  CStdString GetLiveStreamURL(const PVR_CHANNEL& channelinfo);
+  const char * GetLiveStreamURL(const PVR_CHANNEL& channelinfo);

protected:
   virtual void *Process(void);
diff --git a/addons/pvr.dvbviewer/src/client.cpp b/addons/pvr.dvbviewer/src/client.cpp
index 3d0d1e7..6f8ee52 100644
--- a/addons/pvr.dvbviewer/src/client.cpp
+++ b/addons/pvr.dvbviewer/src/client.cpp
@@ -494,7 +494,7 @@ const char *GetLiveStreamURL(const PVR_CHANNEL &channel)
   if (!DvbData || !DvbData->IsConnected())
     return "";

-  return DvbData->GetLiveStreamURL(channel).c_str();
+  return DvbData->GetLiveStreamURL(channel);
}

bool CanPauseStream(void)

Thanks Uukrul, but I'm not developer
Where can I found this solution in compilation file?

The lastest night builds dont work for me in TV online (not view channels)
and neither found information about XBMC+PVR Dvbviewer, seem all is stopped


Thanks in advance
(2013-06-26, 13:59)defcon5 Wrote: [ -> ]Where can I found this solution in compilation file?

You'll have to wait until manül compiles it.

And now, very very sad news. Lars Gehre, the developer of the recording service, died yesterday.
Here is the zip with the fixed addon.
(2013-06-26, 14:07)Uukrul Wrote: [ -> ]And now, very very sad news. Lars Gehre, the developer of the recording service, died yesterday.
I'm sorry about his death. My deepest sympathy to his relatives.

(2013-06-26, 11:36)Uukrul Wrote: [ -> ]I also had the same problem. Here is the fix:
Thanks. However there's still at least one bug left even without timeshift enabled. And that's what most people are suffering from.
I can reproduce this since monday but only on windows. Right know my dev version is crashing during loading the records in https://github.com/manuelm/xbmc-pvr-addo....cpp#L1306 which is just bogus.
(2013-06-26, 14:07)Uukrul Wrote: [ -> ]And now, very very sad news. Lars Gehre, the developer of the recording service, died yesterday.

I´m sadly with this bad news.
Lars helped me a lot in my beginning time with Dvbviewer and Recording service
Rest in peace
(2013-06-15, 22:16)manül Wrote: [ -> ][...] and hope to have something ready to test by the end of next week.
A bit late but anyway.. Here is a snapshot of my current development code. I've uploaded windows builds only for now. If anyone needs another arch, just drop me a message.
There's still a lot to do. But it should be safe to use.

Frodo: Windows
Nightly/Gotham: Windows

Make sure you set your language to english. Everything else will have incorrect translations.

Changes so far:
  • Require DVB viewer recording service 1.25.0 or later
  • In general use RS XML API instead of HTML/channeldat parsing
  • Rewrote channel parsing. Use favourites if you want fast startups.
  • Rewrote recording parsing, generate unique recording IDs
  • Removed signal status information
  • Show available diskspace

NB: Since this is a development snapshot the upcoming release will have the same version number.
Hi

I´m trying test both zip files and when I install zip file from XBMC I get message "Dependencies not met"


Environment:

- Windows 7
- XBMC (lastest nightly and Gotham each with his pvr zip file)
- XBMC in english language



Cheers
(2013-06-28, 12:43)defcon5 Wrote: [ -> ]I´m trying test both zip files and when I install zip file from XBMC I get message "Dependencies not met"
My fault. Forgot to modify the URL for the nightly (nightly is 1.8.10, not 1.6.10) Tongue
Please re-download.
(2013-06-28, 12:46)manül Wrote: [ -> ]
(2013-06-28, 12:43)defcon5 Wrote: [ -> ]I´m trying test both zip files and when I install zip file from XBMC I get message "Dependencies not met"
My fault. Forgot to modify the URL for the nightly (nightly is 1.8.10, not 1.6.10) Tongue
Please re-download.

No problem

I´ll redownload files and I´ll try to test his afternoon

Cheers
Hi,

thanks manül for update! It works fine!

Except that every 5 minutes I get the message that my timers were deleted.
But this message is not the truth. All timers are still available in the web interface of Recordíng Service.

Is it perhaps because these are auto timers?

regards
John
(2013-06-30, 13:41)john.doe Wrote: [ -> ]every 5 minutes I get the message that my timers were deleted.
But this message is not the truth. All timers are still available in the web interface.

Is it perhaps because these are auto timer?
If you're referring to "autosearch timers" then yes, that's possible. I haven't rewritten this part yet but I'll take a short look. Maybe I can filter the internal timers in an easy way.